Commit 82d4afcf authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: host: sl811: remove dentry pointer for debugfs 

There is no need to keep the dentry pointer around for the created
debugfs file, as it is only needed when removing it from the system.
When it is to be removed, ask debugfs itself for the pointer, to save on
storage and make things a bit simpler.

Cc: linux-usb@vger.kernel.org
Link: https://lore.kernel.org/r/20210216144645.3813043-3-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7347f4b9

drivers/usb/host/sl811-hcd.c

+3 −4
Original line number Diff line number Diff line
@@ -1496,14 +1496,13 @@ DEFINE_SHOW_ATTRIBUTE(sl811h_debug); 
/* expect just one sl811 per system */

static void create_debug_file(struct sl811 *sl811)

{

	sl811->debug_file = debugfs_create_file("sl811h", S_IRUGO,

						usb_debug_root, sl811,

	debugfs_create_file("sl811h", S_IRUGO, usb_debug_root, sl811,

			    &sl811h_debug_fops);

}



static void remove_debug_file(struct sl811 *sl811)

{

	debugfs_remove(sl811->debug_file);

	debugfs_remove(debugfs_lookup("sl811h", usb_debug_root));

}



/*-------------------------------------------------------------------------*/

drivers/usb/host/sl811.h

+0 −1
Original line number Diff line number Diff line
@@ -123,7 +123,6 @@ struct sl811 { 
	void __iomem		*addr_reg;

	void __iomem		*data_reg;

	struct sl811_platform_data	*board;

	struct dentry 		*debug_file;



	unsigned long		stat_insrmv;

	unsigned long		stat_wake;