Commit 7347f4b9 authored Feb 16, 2021 by Greg Kroah-Hartman

USB: host: isp1362: remove dentry pointer for debugfs

There is no need to keep the dentry pointer around for the created
debugfs file, as it is only needed when removing it from the system.
When it is to be removed, ask debugfs itself for the pointer, to save on
storage and make things a bit simpler.

Cc: linux-usb@vger.kernel.org
Link: https://lore.kernel.org/r/20210216144645.3813043-2-gregkh@linuxfoundation.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7c7b971d

drivers/usb/host/isp1362-hcd.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -2164,15 +2164,13 @@ DEFINE_SHOW_ATTRIBUTE(isp1362);
		/* expect just one isp1362_hcd per system */
		static void create_debug_file(struct isp1362_hcd *isp1362_hcd)
		{
		isp1362_hcd->debug_file = debugfs_create_file("isp1362", S_IRUGO,
		usb_debug_root,
		isp1362_hcd,
		debugfs_create_file("isp1362", S_IRUGO, usb_debug_root, isp1362_hcd,
		&isp1362_fops);
		}

		static void remove_debug_file(struct isp1362_hcd *isp1362_hcd)
		{
		debugfs_remove(isp1362_hcd->debug_file);
		debugfs_remove(debugfs_lookup("isp1362", usb_debug_root));
		}

		/-------------------------------------------------------------------------/

drivers/usb/host/isp1362.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -435,7 +435,6 @@ struct isp1362_hcd {

		struct isp1362_platform_data *board;

		struct dentry *debug_file;
		unsigned long stat1, stat2, stat4, stat8, stat16;

		/* HC registers */