Commit 82473125 authored by kernel test robot's avatar kernel test robot Committed by Martin K. Petersen
Browse files

scsi: target: tcmu: Fix boolreturn.cocci warnings 

drivers/target/target_core_user.c:1424:9-10: WARNING: return of 0/1 in function 'tcmu_handle_completions' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.

Generated by: scripts/coccinelle/misc/boolreturn.cocci

Link: https://lore.kernel.org/r/20210515230358.GA97544@60d1edce16e0


Fixes: 9814b55c ("scsi: target: tcmu: Return from tcmu_handle_completions() if cmd_id not found")
CC: Bodo Stroesser <bostroesser@gmail.com>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Acked-by: default avatarBodo Stroesser <bostroesser@gmail.com>
Signed-off-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent e2ac7ab2

drivers/target/target_core_user.c

+1 −1
Original line number Diff line number Diff line
@@ -1421,7 +1421,7 @@ static bool tcmu_handle_completions(struct tcmu_dev *udev) 


	if (test_bit(TCMU_DEV_BIT_BROKEN, &udev->flags)) {

		pr_err("ring broken, not handling completions\n");

		return 0;

		return false;

	}



	mb = udev->mb_addr;