Commit 9814b55c authored by Bodo Stroesser's avatar Bodo Stroesser Committed by Martin K. Petersen
Browse files

scsi: target: tcmu: Return from tcmu_handle_completions() if cmd_id not found 

If tcmu_handle_completions() finds an invalid cmd_id while looping over cmd
responses from userspace it sets TCMU_DEV_BIT_BROKEN and breaks the
loop. This means that it does further handling for the tcmu device.

Skip that handling by replacing 'break' with 'return'.

Additionally change tcmu_handle_completions() from unsigned int to bool,
since the value used in return already is bool.

Link: https://lore.kernel.org/r/20210423150123.24468-1-bostroesser@gmail.com


Signed-off-by: default avatarBodo Stroesser <bostroesser@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 2f113714

drivers/target/target_core_user.c

+2 −2
Original line number Diff line number Diff line
@@ -1413,7 +1413,7 @@ static int tcmu_run_tmr_queue(struct tcmu_dev *udev) 
	return 1;

}



static unsigned int tcmu_handle_completions(struct tcmu_dev *udev)

static bool tcmu_handle_completions(struct tcmu_dev *udev)

{

	struct tcmu_mailbox *mb;

	struct tcmu_cmd *cmd;
@@ -1456,7 +1456,7 @@ static unsigned int tcmu_handle_completions(struct tcmu_dev *udev) 
			pr_err("cmd_id %u not found, ring is broken\n",

			       entry->hdr.cmd_id);

			set_bit(TCMU_DEV_BIT_BROKEN, &udev->flags);

			break;

			return false;

		}



		tcmu_handle_completion(cmd, entry);