Commit 820f5ce9 authored by Ben Dooks's avatar Ben Dooks Committed by Vinod Koul
Browse files

dmaengine: dw-axi-dmac: ignore interrupt if no descriptor 



If the channel has no descriptor and the interrupt is raised then the
kernel will OOPS. Check the result of vchan_next_desc() in the handler
axi_chan_block_xfer_complete() to avoid the error happening.

Signed-off-by: default avatarBen Dooks <ben.dooks@sifive.com>
Link: https://lore.kernel.org/r/20220708170153.269991-4-ben.dooks@sifive.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 86cb0def

drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c

+6 −0
Original line number Diff line number Diff line
@@ -1054,6 +1054,11 @@ static void axi_chan_block_xfer_complete(struct axi_dma_chan *chan) 


	/* The completed descriptor currently is in the head of vc list */

	vd = vchan_next_desc(&chan->vc);

	if (!vd) {

		dev_err(chan2dev(chan), "BUG: %s, IRQ with no descriptors\n",

			axi_chan_name(chan));

		goto out;

	}



	if (chan->cyclic) {

		desc = vd_to_axi_desc(vd);
@@ -1083,6 +1088,7 @@ static void axi_chan_block_xfer_complete(struct axi_dma_chan *chan) 
		axi_chan_start_first_queued(chan);

	}



out:

	spin_unlock_irqrestore(&chan->vc.lock, flags);

}