Commit 86cb0def authored by Ben Dooks's avatar Ben Dooks Committed by Vinod Koul
Browse files

dmaengine: dw-axi-dmac: do not print NULL LLI during error 



During debugging we have seen an issue where axi_chan_dump_lli()
is passed a NULL LLI pointer which ends up causing an OOPS due
to trying to get fields from it. Simply print NULL LLI and exit
to avoid this.

Signed-off-by: default avatarBen Dooks <ben.dooks@sifive.com>
Link: https://lore.kernel.org/r/20220708170153.269991-3-ben.dooks@sifive.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 4348d99e

drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c

+5 −0
Original line number Diff line number Diff line
@@ -982,6 +982,11 @@ static int dw_axi_dma_chan_slave_config(struct dma_chan *dchan, 
static void axi_chan_dump_lli(struct axi_dma_chan *chan,

			      struct axi_dma_hw_desc *desc)

{

	if (!desc->lli) {

		dev_err(dchan2dev(&chan->vc.chan), "NULL LLI\n");

		return;

	}



	dev_err(dchan2dev(&chan->vc.chan),

		"SAR: 0x%llx DAR: 0x%llx LLP: 0x%llx BTS 0x%x CTL: 0x%x:%08x",

		le64_to_cpu(desc->lli->sar),