Commit 7d6d4aaf authored Jul 01, 2021 by Uwe Kleine-König Committed by Thierry Reding Jul 08, 2021

pwm: berlin: Ensure configuring period and duty_cycle isn't wrongly skipped

As the last call to berlin_pwm_apply() might have exited early if
state->enabled was false, the values for period and duty_cycle stored in
pwm->state might not have been written to hardware and it must be
ensured that they are configured before enabling the PWM.

Fixes: 30dffb42 ("pwm: berlin: Implement .apply() callback")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 25f70b8f

drivers/pwm/pwm-berlin.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -190,12 +190,9 @@ static int berlin_pwm_apply(struct pwm_chip chip, struct pwm_device pwm,
		return 0;
		}

		if (state->period != pwm->state.period \|\|
		state->duty_cycle != pwm->state.duty_cycle) {
		err = berlin_pwm_config(chip, pwm, state->duty_cycle, state->period);
		if (err)
		return err;
		}

		if (!enabled)
		return berlin_pwm_enable(chip, pwm);