Commit 25f70b8f authored Jul 01, 2021 by Uwe Kleine-König Committed by Thierry Reding Jul 08, 2021

pwm: tiecap: Ensure configuring period and duty_cycle isn't wrongly skipped

As the last call to ecap_pwm_apply() might have exited early if
state->enabled was false, the values for period and duty_cycle stored in
pwm->state might not have been written to hardware and it must be
ensured that they are configured before enabling the PWM.

Fixes: 0ca7acd8 ("pwm: tiecap: Implement .apply() callback")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent fe8255f8

drivers/pwm/pwm-tiecap.c

+6 −9

Original line number	Diff line number	Diff line
		@@ -189,8 +189,6 @@ static int ecap_pwm_apply(struct pwm_chip chip, struct pwm_device pwm,
		return 0;
		}

		if (state->period != pwm->state.period \|\|
		state->duty_cycle != pwm->state.duty_cycle) {
		if (state->period > NSEC_PER_SEC)
		return -ERANGE;

		@@ -198,7 +196,6 @@ static int ecap_pwm_apply(struct pwm_chip chip, struct pwm_device pwm,
		state->period, enabled);
		if (err)
		return err;
		}

		if (!enabled)
		return ecap_pwm_enable(chip, pwm);