Commit 7c7b3e5d authored by Neta Ostrovsky's avatar Neta Ostrovsky Committed by Jason Gunthorpe
Browse files

RDMA/cma: Fix error flow in default_roce_mode_store 

In default_roce_mode_store(), we took a reference to cma_dev, but didn't
return it with cma_dev_put in the error flow.

Fixes: 1c15b4f2 ("RDMA/core: Modify enum ib_gid_type and enum rdma_network_type")
Link: https://lore.kernel.org/r/20210113130214.562108-1-leon@kernel.org


Signed-off-by: default avatarNeta Ostrovsky <netao@nvidia.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 1c3aa6bd

drivers/infiniband/core/cma_configfs.c

+3 −1
Original line number Diff line number Diff line
@@ -131,8 +131,10 @@ static ssize_t default_roce_mode_store(struct config_item *item, 
		return ret;



	gid_type = ib_cache_gid_parse_type_str(buf);

	if (gid_type < 0)

	if (gid_type < 0) {

		cma_configfs_params_put(cma_dev);

		return -EINVAL;

	}



	ret = cma_set_default_gid_type(cma_dev, group->port_num, gid_type);