Commit 1c3aa6bd authored by Mark Bloch's avatar Mark Bloch Committed by Jason Gunthorpe
Browse files

RDMA/mlx5: Fix wrong free of blue flame register on error 

If the allocation of the fast path blue flame register fails, the driver
should free the regular blue flame register allocated a statement above,
not the one that it just failed to allocate.

Fixes: 16c1975f ("IB/mlx5: Create profile infrastructure to add and remove stages")
Link: https://lore.kernel.org/r/20210113121703.559778-6-leon@kernel.org


Reported-by: default avatarHans Petter Selasky <hanss@nvidia.com>
Signed-off-by: default avatarMark Bloch <mbloch@nvidia.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 2cb091f6

drivers/infiniband/hw/mlx5/main.c

+1 −1
Original line number Diff line number Diff line
@@ -4319,7 +4319,7 @@ static int mlx5_ib_stage_bfrag_init(struct mlx5_ib_dev *dev) 


	err = mlx5_alloc_bfreg(dev->mdev, &dev->fp_bfreg, false, true);

	if (err)

		mlx5_free_bfreg(dev->mdev, &dev->fp_bfreg);

		mlx5_free_bfreg(dev->mdev, &dev->bfreg);



	return err;

}