mcb: fix error handling in mcb_alloc_bus()

stable inclusion
from stable-v4.19.209
commit 66f74ba9be9daf9c47fface6af3677f602774f6b
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9R4M2
CVE: CVE-2021-47361

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=66f74ba9be9daf9c47fface6af3677f602774f6b



---------------------------

commit 25a14332 upstream.

There are two bugs:
1) If ida_simple_get() fails then this code calls put_device(carrier)
   but we haven't yet called get_device(carrier) and probably that
   leads to a use after free.
2) After device_initialize() then we need to use put_device() to
   release the bus.  This will free the internal resources tied to the
   device and call mcb_free_bus() which will free the rest.

Fixes: 5d9e2ab9 ("mcb: Implement bus->dev.release callback")
Fixes: 18d28819 ("mcb: Correctly initialize the bus's device")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Johannes Thumshirn <jth@kernel.org>
Link: https://lore.kernel.org/r/32e160cf6864ce77f9d62948338e24db9fd8ead9.1630931319.git.johannes.thumshirn@wdc.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Hui Tang <tanghui20@huawei.com>