Commit 776c9da2 authored by Qinglang Miao's avatar Qinglang Miao Committed by felix
Browse files

i2c: img-scb: fix reference leak when pm_runtime_get_sync fails

stable inclusion
from stable-v5.10.37
commit e80ae8bde41266d3b8bf012460b6593851766006
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I94JR1
CVE: CVE-2020-36783

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e80ae8bde41266d3b8bf012460b6593851766006



--------------------------------

[ Upstream commit 223125e3 ]

The PM reference count is not expected to be incremented on
return in functions img_i2c_xfer and img_i2c_init.

However, pm_runtime_get_sync will increment the PM reference
count even failed. Forgetting to putting operation will result
in a reference leak here.

Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.

Fixes: 93222bd9 ("i2c: img-scb: Add runtime PM")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarQinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarFelix Fu <fuzhen5@huawei.com>
parent ba030414
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment