Commit 747bf30f authored by Shixin Liu's avatar Shixin Liu Committed by Herbert Xu
Browse files

crypto: stm32/cryp - Fix PM reference leak on stm32-cryp.c 



pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: default avatarShixin Liu <liushixin2@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 1cb3ad70

drivers/crypto/stm32/stm32-cryp.c

+2 −2
Original line number Diff line number Diff line
@@ -542,7 +542,7 @@ static int stm32_cryp_hw_init(struct stm32_cryp *cryp) 
	int ret;

	u32 cfg, hw_mode;



	pm_runtime_get_sync(cryp->dev);

	pm_runtime_resume_and_get(cryp->dev);



	/* Disable interrupt */

	stm32_cryp_write(cryp, CRYP_IMSCR, 0);
@@ -2043,7 +2043,7 @@ static int stm32_cryp_remove(struct platform_device *pdev) 
	if (!cryp)

		return -ENODEV;



	ret = pm_runtime_get_sync(cryp->dev);

	ret = pm_runtime_resume_and_get(cryp->dev);

	if (ret < 0)

		return ret;