Commit 1cb3ad70 authored by Shixin Liu's avatar Shixin Liu Committed by Herbert Xu
Browse files

crypto: stm32/hash - Fix PM reference leak on stm32-hash.c 



pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: default avatarShixin Liu <liushixin2@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent cc987ae9

drivers/crypto/stm32/stm32-hash.c

+4 −4
Original line number Diff line number Diff line
@@ -813,7 +813,7 @@ static void stm32_hash_finish_req(struct ahash_request *req, int err) 
static int stm32_hash_hw_init(struct stm32_hash_dev *hdev,

			      struct stm32_hash_request_ctx *rctx)

{

	pm_runtime_get_sync(hdev->dev);

	pm_runtime_resume_and_get(hdev->dev);



	if (!(HASH_FLAGS_INIT & hdev->flags)) {

		stm32_hash_write(hdev, HASH_CR, HASH_CR_INIT);
@@ -962,7 +962,7 @@ static int stm32_hash_export(struct ahash_request *req, void *out) 
	u32 *preg;

	unsigned int i;



	pm_runtime_get_sync(hdev->dev);

	pm_runtime_resume_and_get(hdev->dev);



	while ((stm32_hash_read(hdev, HASH_SR) & HASH_SR_BUSY))

		cpu_relax();
@@ -1000,7 +1000,7 @@ static int stm32_hash_import(struct ahash_request *req, const void *in) 


	preg = rctx->hw_context;



	pm_runtime_get_sync(hdev->dev);

	pm_runtime_resume_and_get(hdev->dev);



	stm32_hash_write(hdev, HASH_IMR, *preg++);

	stm32_hash_write(hdev, HASH_STR, *preg++);
@@ -1566,7 +1566,7 @@ static int stm32_hash_remove(struct platform_device *pdev) 
	if (!hdev)

		return -ENODEV;



	ret = pm_runtime_get_sync(hdev->dev);

	ret = pm_runtime_resume_and_get(hdev->dev);

	if (ret < 0)

		return ret;