Unverified Commit 73f93db5 authored by Paul Kocialkowski's avatar Paul Kocialkowski Committed by Mark Brown
Browse files

spi: core: Initialize returned status in spi_setup 



The previous commit that made bits-per-word validation conditional
results in leaving no unconditional affectation of the status variable.

Since the variable is returned at the end of the function, initialize
it to avoid returning an undefined value.

Signed-off-by: default avatarPaul Kocialkowski <paul.kocialkowski@bootlin.com>
Fixes: b3fe2e51 ("spi: core: Only check bits_per_word validity when explicitly provided")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220414084040.975520-1-paul.kocialkowski@bootlin.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e7cc4244

drivers/spi/spi.c

+1 −1
Original line number Diff line number Diff line
@@ -3474,7 +3474,7 @@ static int __spi_validate_bits_per_word(struct spi_controller *ctlr, 
int spi_setup(struct spi_device *spi)

{

	unsigned	bad_bits, ugly_bits;

	int		status;

	int		status = 0;



	/*

	 * Check mode to prevent that any two of DUAL, QUAD and NO_MOSI/MISO