Commit 734daac9 authored by Jan Kara's avatar Jan Kara Committed by Yongqiang Liu
Browse files

quota: Properly disable quotas when add_dquot_ref() fails

stable inclusion
from stable-v4.19.293
commit 1e69dfc09881f6fe1fd566898d7aa5639d0b6227
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I85XNK


CVE: NA

--------------------------------

[ Upstream commit 6a4e3363 ]

When add_dquot_ref() fails (usually due to IO error or ENOMEM), we want
to disable quotas we are trying to enable. However dquot_disable() call
was passed just the flags we are enabling so in case flags ==
DQUOT_USAGE_ENABLED dquot_disable() call will just fail with EINVAL
instead of properly disabling quotas. Fix the problem by always passing
DQUOT_LIMITS_ENABLED | DQUOT_USAGE_ENABLED to dquot_disable() in this
case.

Reported-and-tested-by: default avatarYe Bin <yebin10@huawei.com>
Reported-by: default avatar <syzbot+e633c79ceaecbf479854@syzkaller.appspotmail.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Message-Id: <20230605140731.2427629-2-yebin10@huawei.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarYongqiang Liu <liuyongqiang13@huawei.com>
parent d23f8017
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment