Commit 701b54bc authored by Mykola Kostenok's avatar Mykola Kostenok Committed by Hans de Goede
Browse files

platform/mellanox: mlxreg-hotplug: Revert "move to use request_irq by IRQF_NO_AUTOEN flag" 



It causes mlxreg-hotplug probing failure: request_threaded_irq()
 returns -EINVAL due to true value of condition:
((irqflags & IRQF_SHARED) && (irqflags & IRQF_NO_AUTOEN))
after flag "IRQF_NO_AUTOEN" has been added to:
	err = devm_request_irq(&pdev->dev, priv->irq,
			       mlxreg_hotplug_irq_handler, IRQF_TRIGGER_FALLING
			       | IRQF_SHARED | IRQF_NO_AUTOEN,
			       "mlxreg-hotplug", priv);

This reverts commit bee3ecfe ("platform/mellanox: mlxreg-hotplug: move
to use request_irq by IRQF_NO_AUTOEN flag").

Signed-off-by: default avatarMykola Kostenok <c_mykolak@nvidia.com>
Acked-by: default avatarVadim Pasternak <vadimp@nvidia.com>
Link: https://lore.kernel.org/r/20210603172827.2599908-1-c_mykolak@nvidia.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 6325ce15

drivers/platform/mellanox/mlxreg-hotplug.c

+2 −2
Original line number Diff line number Diff line
@@ -683,13 +683,13 @@ static int mlxreg_hotplug_probe(struct platform_device *pdev) 


	err = devm_request_irq(&pdev->dev, priv->irq,

			       mlxreg_hotplug_irq_handler, IRQF_TRIGGER_FALLING

			       | IRQF_SHARED | IRQF_NO_AUTOEN,

			       "mlxreg-hotplug", priv);

			       | IRQF_SHARED, "mlxreg-hotplug", priv);

	if (err) {

		dev_err(&pdev->dev, "Failed to request irq: %d\n", err);

		return err;

	}



	disable_irq(priv->irq);

	spin_lock_init(&priv->lock);

	INIT_DELAYED_WORK(&priv->dwork_irq, mlxreg_hotplug_work_handler);

	dev_set_drvdata(&pdev->dev, priv);