Commit bee3ecfe authored by Tian Tao's avatar Tian Tao Committed by Hans de Goede
Browse files

platform/mellanox: mlxreg-hotplug: move to use request_irq by IRQF_NO_AUTOEN flag 

disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.

this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
is being merged: https://lore.kernel.org/patchwork/patch/1388765/



Signed-off-by: default avatarTian Tao <tiantao6@hisilicon.com>
Acked-by: default avatarVadim Pasternak <vadimp@nvidia.com>
Link: https://lore.kernel.org/r/1617785983-28878-1-git-send-email-tiantao6@hisilicon.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent bbca17c0

drivers/platform/mellanox/mlxreg-hotplug.c

+2 −2
Original line number Diff line number Diff line
@@ -683,13 +683,13 @@ static int mlxreg_hotplug_probe(struct platform_device *pdev) 


	err = devm_request_irq(&pdev->dev, priv->irq,

			       mlxreg_hotplug_irq_handler, IRQF_TRIGGER_FALLING

			       | IRQF_SHARED, "mlxreg-hotplug", priv);

			       | IRQF_SHARED | IRQF_NO_AUTOEN,

			       "mlxreg-hotplug", priv);

	if (err) {

		dev_err(&pdev->dev, "Failed to request irq: %d\n", err);

		return err;

	}



	disable_irq(priv->irq);

	spin_lock_init(&priv->lock);

	INIT_DELAYED_WORK(&priv->dwork_irq, mlxreg_hotplug_work_handler);

	dev_set_drvdata(&pdev->dev, priv);