Commit 6fd6eda0 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

qed: remove pointless call to devlink_param_driverinit_value_set() 



devlink_param_driverinit_value_set() call makes sense only for "
driverinit" params. However here, the param is "runtime".
devlink_param_driverinit_value_set() returns -EOPNOTSUPP in such case
and does not do anything. So remove the pointless call to
devlink_param_driverinit_value_set() entirely.

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2fc631b5

drivers/net/ethernet/qlogic/qed/qed_devlink.c

+0 −6
Original line number Diff line number Diff line
@@ -198,7 +198,6 @@ static const struct devlink_ops qed_dl_ops = { 


struct devlink *qed_devlink_register(struct qed_dev *cdev)

{

	union devlink_param_value value;

	struct qed_devlink *qdevlink;

	struct devlink *dl;

	int rc;
@@ -216,11 +215,6 @@ struct devlink *qed_devlink_register(struct qed_dev *cdev) 
	if (rc)

		goto err_unregister;



	value.vbool = false;

	devlink_param_driverinit_value_set(dl,

					   QED_DEVLINK_PARAM_ID_IWARP_CMT,

					   value);



	cdev->iwarp_cmt = false;



	qed_fw_reporters_create(dl);