Commit 2fc631b5 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

ice: remove pointless calls to devlink_param_driverinit_value_set() 



devlink_param_driverinit_value_set() call makes sense only for
"driverinit" params. However here, both params are "runtime".
devlink_param_driverinit_value_set() returns -EOPNOTSUPP in such case
and does not do anything. So remove the pointless calls to
devlink_param_driverinit_value_set() entirely.

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bb9bb6bf

drivers/net/ethernet/intel/ice/ice_devlink.c

+2 −18
Original line number Diff line number Diff line
@@ -1411,25 +1411,9 @@ ice_devlink_set_switch_id(struct ice_pf *pf, struct netdev_phys_item_id *ppid) 
int ice_devlink_register_params(struct ice_pf *pf)

{

	struct devlink *devlink = priv_to_devlink(pf);

	union devlink_param_value value;

	int err;



	err = devlink_params_register(devlink, ice_devlink_params,

	return devlink_params_register(devlink, ice_devlink_params,

				       ARRAY_SIZE(ice_devlink_params));

	if (err)

		return err;



	value.vbool = false;

	devlink_param_driverinit_value_set(devlink,

					   DEVLINK_PARAM_GENERIC_ID_ENABLE_IWARP,

					   value);



	value.vbool = test_bit(ICE_FLAG_RDMA_ENA, pf->flags) ? true : false;

	devlink_param_driverinit_value_set(devlink,

					   DEVLINK_PARAM_GENERIC_ID_ENABLE_ROCE,

					   value);



	return 0;

}



void ice_devlink_unregister_params(struct ice_pf *pf)