Commit 6f5168f5 authored by Sagi Grimberg's avatar Sagi Grimberg Committed by openeuler-sync-bot
Browse files

nvmet-tcp: Fix a possible UAF in queue intialization setup

mainline inclusion
from mainline-v6.6-rc7
commit d920abd1
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I88DLS
CVE: CVE-2023-5178

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.6&id=d920abd1e7c4884f9ecd0749d1921b7ab19ddfbd



-------------------------------------------------

From Alon:
"Due to a logical bug in the NVMe-oF/TCP subsystem in the Linux kernel,
a malicious user can cause a UAF and a double free, which may lead to
RCE (may also lead to an LPE in case the attacker already has local
privileges)."

Hence, when a queue initialization fails after the ahash requests are
allocated, it is guaranteed that the queue removal async work will be
called, hence leave the deallocation to the queue removal.

Also, be extra careful not to continue processing the socket, so set
queue rcv_state to NVMET_TCP_RECV_ERR upon a socket error.

Cc: stable@vger.kernel.org
Reported-by: default avatarAlon Zahavi <zahavi.alon@gmail.com>
Tested-by: default avatarAlon Zahavi <zahavi.alon@gmail.com>
Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarLi Lingfeng <lilingfeng3@huawei.com>
(cherry picked from commit ef848f65)
parent 089561eb
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment