Commit 6f4432ba authored by Qiushi Wu's avatar Qiushi Wu Committed by Mauro Carvalho Chehab
Browse files

media: sti: Fix reference count leaks 



pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, causing incorrect ref count if
pm_runtime_put_noidle() is not called in error handling paths.
Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.

Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 7ef64cee

drivers/media/platform/sti/hva/hva-hw.c

+2 −0
Original line number Diff line number Diff line
@@ -272,6 +272,7 @@ static unsigned long int hva_hw_get_ip_version(struct hva_dev *hva) 


	if (pm_runtime_get_sync(dev) < 0) {

		dev_err(dev, "%s     failed to get pm_runtime\n", HVA_PREFIX);

		pm_runtime_put_noidle(dev);

		mutex_unlock(&hva->protect_mutex);

		return -EFAULT;

	}
@@ -553,6 +554,7 @@ void hva_hw_dump_regs(struct hva_dev *hva, struct seq_file *s) 


	if (pm_runtime_get_sync(dev) < 0) {

		seq_puts(s, "Cannot wake up IP\n");

		pm_runtime_put_noidle(dev);

		mutex_unlock(&hva->protect_mutex);

		return;

	}