Commit 7ef64cee authored by Qiushi Wu's avatar Qiushi Wu Committed by Mauro Carvalho Chehab
Browse files

media: exynos4-is: Fix several reference count leaks due to pm_runtime_get_sync 



On calling pm_runtime_get_sync() the reference count of the device
is incremented. In case of failure, decrement the
reference count before returning the error.

Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent c47f7c77

drivers/media/platform/exynos4-is/fimc-isp.c

+3 −1
Original line number Diff line number Diff line
@@ -305,8 +305,10 @@ static int fimc_isp_subdev_s_power(struct v4l2_subdev *sd, int on) 


	if (on) {

		ret = pm_runtime_get_sync(&is->pdev->dev);

		if (ret < 0)

		if (ret < 0) {

			pm_runtime_put(&is->pdev->dev);

			return ret;

		}

		set_bit(IS_ST_PWR_ON, &is->state);



		ret = fimc_is_start_firmware(is);

drivers/media/platform/exynos4-is/fimc-lite.c

+1 −1
Original line number Diff line number Diff line
@@ -471,7 +471,7 @@ static int fimc_lite_open(struct file *file) 
	set_bit(ST_FLITE_IN_USE, &fimc->state);

	ret = pm_runtime_get_sync(&fimc->pdev->dev);

	if (ret < 0)

		goto unlock;

		goto err_pm;



	ret = v4l2_fh_open(file);

	if (ret < 0)