Commit 6f2f6eaf authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf pmu: Reduce scope of perf_pmu_error() 



Move declaration from header file to pmu.y and make static.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jing Zhang <renyu.zj@linux.alibaba.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230823080828.1460376-5-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent cc5adb73

tools/perf/util/pmu.h

+0 −1
Original line number Diff line number Diff line
@@ -227,7 +227,6 @@ int perf_pmu__check_alias(struct perf_pmu *pmu, struct list_head *head_terms, 
			  struct perf_pmu_info *info);

struct list_head *perf_pmu__alias(struct perf_pmu *pmu,

				  struct list_head *head_terms);

void perf_pmu_error(struct list_head *list, char *name, void *scanner, char const *msg);



int perf_pmu__new_format(struct list_head *list, char *name,

			 int config, unsigned long *bits);

tools/perf/util/pmu.y

+3 −1
Original line number Diff line number Diff line
@@ -21,6 +21,8 @@ do { \ 
                YYABORT; \

} while (0)



static void perf_pmu_error(struct list_head *list, char *name, void *scanner, char const *msg);



static void perf_pmu__set_format(unsigned long *bits, long from, long to)

{

	long b;
@@ -93,7 +95,7 @@ PP_VALUE 


%%



void perf_pmu_error(struct list_head *list __maybe_unused,

static void perf_pmu_error(struct list_head *list __maybe_unused,

		    char *name __maybe_unused,

		    void *scanner __maybe_unused,

		    char const *msg __maybe_unused)