Commit cc5adb73 authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf pmu: Move perf_pmu__set_format to pmu.y 



Avoid having the function in the C and header file, as it is only used
locally by pmu.y.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jing Zhang <renyu.zj@linux.alibaba.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230823080828.1460376-4-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent e1a3aad3

tools/perf/util/pmu.c

+0 −12
Original line number Diff line number Diff line
@@ -1417,18 +1417,6 @@ int perf_pmu__new_format(struct list_head *list, char *name, 
	return 0;

}



void perf_pmu__set_format(unsigned long *bits, long from, long to)

{

	long b;



	if (!to)

		to = from;



	memset(bits, 0, BITS_TO_BYTES(PERF_PMU_FORMAT_BITS));

	for (b = from; b <= to; b++)

		__set_bit(b, bits);

}



void perf_pmu__del_formats(struct list_head *formats)

{

	struct perf_pmu_format *fmt, *tmp;

tools/perf/util/pmu.h

+0 −1
Original line number Diff line number Diff line
@@ -231,7 +231,6 @@ void perf_pmu_error(struct list_head *list, char *name, void *scanner, char cons 


int perf_pmu__new_format(struct list_head *list, char *name,

			 int config, unsigned long *bits);

void perf_pmu__set_format(unsigned long *bits, long from, long to);

int perf_pmu__format_parse(int dirfd, struct list_head *head);

void perf_pmu__del_formats(struct list_head *formats);

bool perf_pmu__has_format(const struct perf_pmu *pmu, const char *name);

tools/perf/util/pmu.y

+12 −0
Original line number Diff line number Diff line
@@ -21,6 +21,18 @@ do { \ 
                YYABORT; \

} while (0)



static void perf_pmu__set_format(unsigned long *bits, long from, long to)

{

	long b;



	if (!to)

		to = from;



	memset(bits, 0, BITS_TO_BYTES(PERF_PMU_FORMAT_BITS));

	for (b = from; b <= to; b++)

		__set_bit(b, bits);

}



%}



%token PP_CONFIG