Commit 6eff5721 authored by Dan Williams's avatar Dan Williams
Browse files

cxl/mem: Use sysfs_emit() for attribute show routines 



While none the CXL sysfs attributes are threatening to overrun a
PAGE_SIZE of output, it is good form to use the recommended helpers.

Fixes: b39cb105 ("cxl/mem: Register CXL memX devices")
Reported-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Reviewed-by: default avatarBen Widawsky <ben.widawsky@intel.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/161728759424.2474381.11231441014951343463.stgit@dwillia2-desk3.amr.corp.intel.com


Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent a38fd874

drivers/cxl/mem.c

+4 −4
Original line number Diff line number Diff line
@@ -1066,7 +1066,7 @@ static ssize_t firmware_version_show(struct device *dev, 
	struct cxl_memdev *cxlmd = to_cxl_memdev(dev);

	struct cxl_mem *cxlm = cxlmd->cxlm;



	return sprintf(buf, "%.16s\n", cxlm->firmware_version);

	return sysfs_emit(buf, "%.16s\n", cxlm->firmware_version);

}

static DEVICE_ATTR_RO(firmware_version);
@@ -1076,7 +1076,7 @@ static ssize_t payload_max_show(struct device *dev, 
	struct cxl_memdev *cxlmd = to_cxl_memdev(dev);

	struct cxl_mem *cxlm = cxlmd->cxlm;



	return sprintf(buf, "%zu\n", cxlm->payload_size);

	return sysfs_emit(buf, "%zu\n", cxlm->payload_size);

}

static DEVICE_ATTR_RO(payload_max);
@@ -1087,7 +1087,7 @@ static ssize_t ram_size_show(struct device *dev, struct device_attribute *attr, 
	struct cxl_mem *cxlm = cxlmd->cxlm;

	unsigned long long len = range_len(&cxlm->ram_range);



	return sprintf(buf, "%#llx\n", len);

	return sysfs_emit(buf, "%#llx\n", len);

}



static struct device_attribute dev_attr_ram_size =
@@ -1100,7 +1100,7 @@ static ssize_t pmem_size_show(struct device *dev, struct device_attribute *attr, 
	struct cxl_mem *cxlm = cxlmd->cxlm;

	unsigned long long len = range_len(&cxlm->pmem_range);



	return sprintf(buf, "%#llx\n", len);

	return sysfs_emit(buf, "%#llx\n", len);

}



static struct device_attribute dev_attr_pmem_size =