Commit 6b4040f4 authored Feb 02, 2023 by Greg Kroah-Hartman

USB: fotg210: fix memory leak with using debugfs_lookup()



When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20230202153235.2412790-5-gregkh@linuxfoundation.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e1523c4d

drivers/usb/fotg210/fotg210-hcd.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -861,7 +861,7 @@ static inline void remove_debug_files(struct fotg210_hcd *fotg210)
	{		{
	struct usb_bus *bus = &fotg210_to_hcd(fotg210)->self;		struct usb_bus *bus = &fotg210_to_hcd(fotg210)->self;

	debugfs_remove(debugfs_lookup(bus->bus_name, fotg210_debug_root));		debugfs_lookup_and_remove(bus->bus_name, fotg210_debug_root);
	}		}

	/* handshake - spin reading hc until handshake completes or fails		/* handshake - spin reading hc until handshake completes or fails