Commit e1523c4d authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: sl811: fix memory leak with using debugfs_lookup() 

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Link: https://lore.kernel.org/r/20230202153235.2412790-4-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0a3f82c7

drivers/usb/host/sl811-hcd.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1501,7 +1501,7 @@ static void create_debug_file(struct sl811 *sl811) 




static void remove_debug_file(struct sl811 *sl811)

static void remove_debug_file(struct sl811 *sl811)

{

{

	debugfs_remove(debugfs_lookup("sl811h", usb_debug_root));

	debugfs_lookup_and_remove("sl811h", usb_debug_root);

}

}





/*-------------------------------------------------------------------------*/

/*-------------------------------------------------------------------------*/