Commit 6b1dba3d authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Martin K. Petersen
Browse files

scsi: target: file: Don't zero iter before iov_iter_bvec 

iov_iter_bvec() initialises iterators well, no need to pre-zero it
beforehand as done in fd_execute_rw_aio(). Compilers can't optimise it out
and generate extra code for that (confirmed with assembly).

Link: https://lore.kernel.org/r/34cd22d6cec046e3adf402accb1453cc255b9042.1610207523.git.asml.silence@gmail.com


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 4f608fbc

drivers/target/target_core_file.c

+1 −1
Original line number Diff line number Diff line
@@ -266,7 +266,7 @@ fd_execute_rw_aio(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, 
	struct fd_dev *fd_dev = FD_DEV(dev);

	struct file *file = fd_dev->fd_file;

	struct target_core_file_cmd *aio_cmd;

	struct iov_iter iter = {};

	struct iov_iter iter;

	struct scatterlist *sg;

	struct bio_vec *bvec;

	ssize_t len = 0;