Commit 4f608fbc authored Jan 09, 2021 by Vishakha Channapattan Committed by Martin K. Petersen Jan 13, 2021

scsi: pm80xx: Log SATA IOMB completion status on failure

Added a log message in SATA completion path to capture the status of failed
command. If the status does not match any expected status, another message
will be logged.

On IO failure with known status, the log message will be:

  [ 1712.951735] pm80xx0:: mpi_sata_completion 2269: IO failed device_id 16385 status 0x1 tag XX

If the firmware returns unexpected status, a message of the following
format will be logged:

  [ 1712.951735] pm80xx0:: mpi_sata_completion XXXX: Unknown status device_id XXXXX status 0xX tag XX

Link: https://lore.kernel.org/r/20210109123849.17098-8-Viswas.G@microchip.com


Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Vishakha Channapattan <vishakhavc@google.com>
Signed-off-by: Viswas G <Viswas.G@microchip.com>
Signed-off-by: Ruksar Devadi <Ruksar.devadi@microchip.com>
Signed-off-by: Ashokkumar N <Ashokkumar.N@microchip.com>
Signed-off-by: Radha Ramachandran <radha@google.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 6b2f2d05

drivers/scsi/pm8001/pm80xx_hwi.c

+8 −5

Original line number	Diff line number	Diff line
		@@ -2437,10 +2437,11 @@ mpi_sata_completion(struct pm8001_hba_info pm8001_ha, void piomb)
		return;
		}

		if (unlikely(status))
		pm8001_dbg(pm8001_ha, IOERR,
		"status:0x%x, tag:0x%x, task::0x%p\n",
		status, tag, t);
		if (status != IO_SUCCESS) {
		pm8001_dbg(pm8001_ha, FAIL,
		"IO failed device_id %u status 0x%x tag %d\n",
		pm8001_dev->device_id, status, tag);
		}

		/* Print sas address of IO failed device */
		if ((status != IO_SUCCESS) && (status != IO_OVERFLOW) &&
		@@ -2762,7 +2763,9 @@ mpi_sata_completion(struct pm8001_hba_info pm8001_ha, void piomb)
		atomic_dec(&pm8001_dev->running_req);
		break;
		default:
		pm8001_dbg(pm8001_ha, DEVIO, "Unknown status 0x%x\n", status);
		pm8001_dbg(pm8001_ha, DEVIO,
		"Unknown status device_id %u status 0x%x tag %d\n",
		pm8001_dev->device_id, status, tag);
		/* not allowed case. Therefore, return failed status */
		ts->resp = SAS_TASK_COMPLETE;
		ts->stat = SAS_DEV_NO_RESPONSE;