Commit 6a1ec89f authored by Tony Lindgren's avatar Tony Lindgren Committed by Herbert Xu
Browse files

crypto: omap-sham - initialize req only after omap_sham_hw_init() 



Let's only initialize dd->req after omap_sham_hw_init() in case of
errors.

Looks like leaving dd->req initialized on omap_sham_hw_init() errors is
is not causing issues though as we return on errors. So this patch can be
applied as clean-up.

Cc: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Tero Kristo <kristo@kernel.org>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent fe28140b

drivers/crypto/omap-sham.c

+2 −2
Original line number Diff line number Diff line
@@ -1093,12 +1093,12 @@ static int omap_sham_hash_one_req(struct crypto_engine *engine, void *areq) 
	dev_dbg(dd->dev, "hash-one: op: %u, total: %u, digcnt: %zd, final: %d",

		ctx->op, ctx->total, ctx->digcnt, final);



	dd->req = req;



	err = omap_sham_hw_init(dd);

	if (err)

		return err;



	dd->req = req;



	if (ctx->digcnt)

		dd->pdata->copy_hash(req, 0);