Commit fe28140b authored Jul 27, 2021 by Tony Lindgren Committed by Herbert Xu Aug 06, 2021

crypto: omap-sham - clear dma flags only after omap_sham_update_dma_stop()



We should not clear FLAGS_DMA_ACTIVE before omap_sham_update_dma_stop() is
done calling dma_unmap_sg(). We already clear FLAGS_DMA_ACTIVE at the
end of omap_sham_update_dma_stop().

The early clearing of FLAGS_DMA_ACTIVE is not causing issues as we do not
need to defer anything based on FLAGS_DMA_ACTIVE currently. So this can be
applied as clean-up.

Cc: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Tero Kristo <kristo@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 089015d3

drivers/crypto/omap-sham.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1736,7 +1736,7 @@ static void omap_sham_done_task(unsigned long data)
		if (test_and_clear_bit(FLAGS_OUTPUT_READY, &dd->flags))
		goto finish;
		} else if (test_bit(FLAGS_DMA_READY, &dd->flags)) {
		if (test_and_clear_bit(FLAGS_DMA_ACTIVE, &dd->flags)) {
		if (test_bit(FLAGS_DMA_ACTIVE, &dd->flags)) {
		omap_sham_update_dma_stop(dd);
		if (dd->err) {
		err = dd->err;