Commit 69a18745 authored by Martin Kepplinger's avatar Martin Kepplinger Committed by Mauro Carvalho Chehab
Browse files

media: i2c: hi846: use pm_runtime_force_suspend/resume for system suspend 



In cases like this when controlling regulators and clocks the suspend()
and resume() functions are meant to be called balanced toggling the behaviour.

It's wrong to use the same suspend function for runtime and system suspend
in this case and leads to errors like

[   77.718890] Failed to disable vddd: -EIO

Use pm_runtime_force_* helpers in order to support system suspend properly
when runtime pm is already implemented and fix this.

Signed-off-by: default avatarMartin Kepplinger <martin.kepplinger@puri.sm>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent e1cc0a05

drivers/media/i2c/hi846.c

+5 −1
Original line number Diff line number Diff line
@@ -2162,7 +2162,11 @@ static int hi846_remove(struct i2c_client *client) 
	return 0;

}



static UNIVERSAL_DEV_PM_OPS(hi846_pm_ops, hi846_suspend, hi846_resume, NULL);

static const struct dev_pm_ops hi846_pm_ops = {

	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,

				pm_runtime_force_resume)

	SET_RUNTIME_PM_OPS(hi846_suspend, hi846_resume, NULL)

};



static const struct of_device_id hi846_of_match[] = {

	{ .compatible = "hynix,hi846", },