Commit e1cc0a05 authored by Martin Kepplinger's avatar Martin Kepplinger Committed by Mauro Carvalho Chehab
Browse files

media: i2c: hi846: check return value of regulator_bulk_disable() 



regulator_bulk_disable can fail and thus suspend() can. Handle that error
gracefully.

Signed-off-by: default avatarMartin Kepplinger <martin.kepplinger@puri.sm>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent d1d2ed59

drivers/media/i2c/hi846.c

+3 −5
Original line number Diff line number Diff line
@@ -1656,7 +1656,7 @@ static int hi846_power_on(struct hi846 *hi846) 
	return ret;

}



static void hi846_power_off(struct hi846 *hi846)

static int hi846_power_off(struct hi846 *hi846)

{

	if (hi846->rst_gpio)

		gpiod_set_value_cansleep(hi846->rst_gpio, 1);
@@ -1665,7 +1665,7 @@ static void hi846_power_off(struct hi846 *hi846) 
		gpiod_set_value_cansleep(hi846->shutdown_gpio, 1);



	clk_disable_unprepare(hi846->clock);

	regulator_bulk_disable(HI846_NUM_SUPPLIES, hi846->supplies);

	return regulator_bulk_disable(HI846_NUM_SUPPLIES, hi846->supplies);

}



static int __maybe_unused hi846_suspend(struct device *dev)
@@ -1677,9 +1677,7 @@ static int __maybe_unused hi846_suspend(struct device *dev) 
	if (hi846->streaming)

		hi846_stop_streaming(hi846);



	hi846_power_off(hi846);



	return 0;

	return hi846_power_off(hi846);

}



static int __maybe_unused hi846_resume(struct device *dev)