Commit 688fcd04 authored by Armin Wolf's avatar Armin Wolf Committed by Guenter Roeck
Browse files

hwmon: (dell-smm) Move error message to make probing silent 



If dell-smm-hwmon loads on unsupported hardware like the
Dell XPS 17 9710, an error message is printed.
This might confuse users, as drivers are expected to be
silent if no supported hardware is found.
Reorder the error message so its only printed when the
driver is loaded with the "force" option being set.
Also reword the error message slightly.

Tested on a Dell Inspiron 3505.

Signed-off-by: default avatarArmin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20221130183418.357246-1-W_Armin@gmx.de


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 4e6104b1

drivers/hwmon/dell-smm-hwmon.c

+2 −1
Original line number Diff line number Diff line
@@ -1447,9 +1447,10 @@ static int __init i8k_init(void) 
	 */

	if (i8k_get_dell_signature(I8K_SMM_GET_DELL_SIG1) &&

	    i8k_get_dell_signature(I8K_SMM_GET_DELL_SIG2)) {

		pr_err("unable to get SMM Dell signature\n");

		if (!force)

			return -ENODEV;



		pr_err("Unable to get Dell SMM signature\n");

	}



	dell_smm_device = platform_create_bundle(&dell_smm_driver, dell_smm_probe, NULL, 0, NULL,