Commit 4e6104b1 authored by ye xingchen's avatar ye xingchen Committed by Guenter Roeck
Browse files

hwmon: use sysfs_emit() to instead of scnprintf() 



Replace the open-code with sysfs_emit() to simplify the code.

Signed-off-by: default avatarye xingchen <ye.xingchen@zte.com.cn>
Link: https://lore.kernel.org/r/202212011130317080061@zte.com.cn


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 0cd3ba68

drivers/hwmon/ds1621.c

+1 −1
Original line number Diff line number Diff line
@@ -269,7 +269,7 @@ static ssize_t update_interval_show(struct device *dev, 
				    struct device_attribute *da, char *buf)

{

	struct ds1621_data *data = dev_get_drvdata(dev);

	return scnprintf(buf, PAGE_SIZE, "%hu\n", data->update_interval);

	return sysfs_emit(buf, "%hu\n", data->update_interval);

}



static ssize_t update_interval_store(struct device *dev,

drivers/hwmon/lm73.c

+3 −3
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ static ssize_t temp_show(struct device *dev, struct device_attribute *da, 
	/* use integer division instead of equivalent right shift to

	   guarantee arithmetic shift and preserve the sign */

	temp = (((s16) err) * 250) / 32;

	return scnprintf(buf, PAGE_SIZE, "%d\n", temp);

	return sysfs_emit(buf, "%d\n", temp);

}



static ssize_t convrate_store(struct device *dev, struct device_attribute *da,
@@ -137,7 +137,7 @@ static ssize_t convrate_show(struct device *dev, struct device_attribute *da, 
	int res;



	res = (data->ctrl & LM73_CTRL_RES_MASK) >> LM73_CTRL_RES_SHIFT;

	return scnprintf(buf, PAGE_SIZE, "%hu\n", lm73_convrates[res]);

	return sysfs_emit(buf, "%hu\n", lm73_convrates[res]);

}



static ssize_t maxmin_alarm_show(struct device *dev,
@@ -154,7 +154,7 @@ static ssize_t maxmin_alarm_show(struct device *dev, 
	data->ctrl = ctrl;

	mutex_unlock(&data->lock);



	return scnprintf(buf, PAGE_SIZE, "%d\n", (ctrl >> attr->index) & 1);

	return sysfs_emit(buf, "%d\n", (ctrl >> attr->index) & 1);



abort:

	mutex_unlock(&data->lock);

drivers/hwmon/sht3x.c

+6 −6
Original line number Diff line number Diff line
@@ -320,7 +320,7 @@ static ssize_t temp1_limit_show(struct device *dev, 
	u8 index = to_sensor_dev_attr(attr)->index;

	int temperature_limit = data->temperature_limits[index];



	return scnprintf(buf, PAGE_SIZE, "%d\n", temperature_limit);

	return sysfs_emit(buf, "%d\n", temperature_limit);

}



static ssize_t humidity1_limit_show(struct device *dev,
@@ -331,7 +331,7 @@ static ssize_t humidity1_limit_show(struct device *dev, 
	u8 index = to_sensor_dev_attr(attr)->index;

	u32 humidity_limit = data->humidity_limits[index];



	return scnprintf(buf, PAGE_SIZE, "%u\n", humidity_limit);

	return sysfs_emit(buf, "%u\n", humidity_limit);

}



/*
@@ -483,7 +483,7 @@ static ssize_t temp1_alarm_show(struct device *dev, 
	if (ret)

		return ret;



	return scnprintf(buf, PAGE_SIZE, "%d\n", !!(buffer[0] & 0x04));

	return sysfs_emit(buf, "%d\n", !!(buffer[0] & 0x04));

}



static ssize_t humidity1_alarm_show(struct device *dev,
@@ -498,7 +498,7 @@ static ssize_t humidity1_alarm_show(struct device *dev, 
	if (ret)

		return ret;



	return scnprintf(buf, PAGE_SIZE, "%d\n", !!(buffer[0] & 0x08));

	return sysfs_emit(buf, "%d\n", !!(buffer[0] & 0x08));

}



static ssize_t heater_enable_show(struct device *dev,
@@ -513,7 +513,7 @@ static ssize_t heater_enable_show(struct device *dev, 
	if (ret)

		return ret;



	return scnprintf(buf, PAGE_SIZE, "%d\n", !!(buffer[0] & 0x20));

	return sysfs_emit(buf, "%d\n", !!(buffer[0] & 0x20));

}



static ssize_t heater_enable_store(struct device *dev,
@@ -550,7 +550,7 @@ static ssize_t update_interval_show(struct device *dev, 
{

	struct sht3x_data *data = dev_get_drvdata(dev);



	return scnprintf(buf, PAGE_SIZE, "%u\n",

	return sysfs_emit(buf, "%u\n",

			 mode_to_update_interval[data->mode]);

}