Commit 66daf3e6 authored by Lukas Bulwahn's avatar Lukas Bulwahn Committed by Martin K. Petersen
Browse files

scsi: scsi_ioctl: Drop needless assignment in sg_io() 

Commit ce70fd9a ("scsi: core: Remove the cmd field from struct
scsi_request") refactored sg_io(), so that it does not allocate directly
and hence does not return -ENOMEM in its error case. That makes a remaining
assignment of -ENOMEM to the return variable needless.

Drop this needless assignment in sg_io().

No functional change. No change in resulting object code.

Link: https://lore.kernel.org/r/20220315061520.30745-1-lukas.bulwahn@gmail.com


Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarLukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent dc155e1a

drivers/scsi/scsi_ioctl.c

+0 −1
Original line number Diff line number Diff line
@@ -434,7 +434,6 @@ static int sg_io(struct scsi_device *sdev, struct sg_io_hdr *hdr, fmode_t mode) 
	if (hdr->flags & SG_FLAG_Q_AT_HEAD)

		at_head = 1;



	ret = -ENOMEM;

	rq = scsi_alloc_request(sdev->request_queue, writing ?

			     REQ_OP_DRV_OUT : REQ_OP_DRV_IN, 0);

	if (IS_ERR(rq))