Commit dc155e1a authored by Lukas Bulwahn's avatar Lukas Bulwahn Committed by Martin K. Petersen
Browse files

scsi: bsg: Drop needless assignment in scsi_bsg_sg_io_fn() 

Commit ce70fd9a ("scsi: core: Remove the cmd field from struct
scsi_request") refactored scsi_bsg_sg_io_fn() so that it does not allocate
directly and hence does not return -ENOMEM in its error case.  That makes a
remaining assignment of -ENOMEM to the return variable needless.

Drop this needless assignment in scsi_bsg_sg_io_fn().

No functional change. No change in resulting object code.

Link: https://lore.kernel.org/r/20220315055325.14974-1-lukas.bulwahn@gmail.com


Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarLukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f45775bf

drivers/scsi/scsi_bsg.c

+0 −1
Original line number Diff line number Diff line
@@ -31,7 +31,6 @@ static int scsi_bsg_sg_io_fn(struct request_queue *q, struct sg_io_v4 *hdr, 
		return PTR_ERR(rq);

	rq->timeout = timeout;



	ret = -ENOMEM;

	scmd = blk_mq_rq_to_pdu(rq);

	scmd->cmd_len = hdr->request_len;

	if (scmd->cmd_len > sizeof(scmd->cmnd)) {