Commit 647e6cc9 authored by Maximilian Luz's avatar Maximilian Luz Committed by Hans de Goede
Browse files

platform/surface: aggregator: Do not mark interrupt as shared 



Having both IRQF_NO_AUTOEN and IRQF_SHARED set causes
request_threaded_irq() to return with -EINVAL (see comment in flag
validation in that function). As the interrupt is currently not shared
between multiple devices, drop the IRQF_SHARED flag.

Fixes: 507cf5a2 ("platform/surface: aggregator: move to use request_irq by IRQF_NO_AUTOEN flag")
Signed-off-by: default avatarMaximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210505133635.1499703-1-luzmaximilian@gmail.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 79d341e2

drivers/platform/surface/aggregator/controller.c

+1 −2
Original line number Diff line number Diff line
@@ -2483,8 +2483,7 @@ int ssam_irq_setup(struct ssam_controller *ctrl) 
	 * interrupt, and let the SAM resume callback during the controller

	 * resume process clear it.

	 */

	const int irqf = IRQF_SHARED | IRQF_ONESHOT |

			 IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN;

	const int irqf = IRQF_ONESHOT | IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN;



	gpiod = gpiod_get(dev, "ssam_wakeup-int", GPIOD_ASIS);

	if (IS_ERR(gpiod))