Commit 507cf5a2 authored by Tian Tao's avatar Tian Tao Committed by Hans de Goede
Browse files

platform/surface: aggregator: move to use request_irq by IRQF_NO_AUTOEN flag 

disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.

this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
is being merged: https://lore.kernel.org/patchwork/patch/1388765/



Signed-off-by: default avatarTian Tao <tiantao6@hisilicon.com>
Reviewed-by: default avatarMaximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/1617778852-26492-1-git-send-email-tiantao6@hisilicon.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent bee3ecfe

drivers/platform/surface/aggregator/controller.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -2483,7 +2483,8 @@ int ssam_irq_setup(struct ssam_controller *ctrl) 
	 * interrupt, and let the SAM resume callback during the controller

	 * interrupt, and let the SAM resume callback during the controller

	 * resume process clear it.

	 * resume process clear it.

	 */

	 */

	const int irqf = IRQF_SHARED | IRQF_ONESHOT | IRQF_TRIGGER_RISING;

	const int irqf = IRQF_SHARED | IRQF_ONESHOT |

			 IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN;





	gpiod = gpiod_get(dev, "ssam_wakeup-int", GPIOD_ASIS);

	gpiod = gpiod_get(dev, "ssam_wakeup-int", GPIOD_ASIS);

	if (IS_ERR(gpiod))

	if (IS_ERR(gpiod))
@@ -2501,7 +2502,6 @@ int ssam_irq_setup(struct ssam_controller *ctrl) 
		return status;

		return status;





	ctrl->irq.num = irq;

	ctrl->irq.num = irq;

	disable_irq(ctrl->irq.num);

	return 0;

	return 0;

}

}