usb: raw-gadget: properly handle interrupted requests
stable inclusion from stable-v6.6.1 commit 45285dba03619f653b86678d812966373142406b category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8IKRU Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=45285dba03619f653b86678d812966373142406b -------------------------------- commit e8033bde451eddfb9b1bbd6e2d848c1b5c277222 upstream. Currently, if a USB request that was queued by Raw Gadget is interrupted (via a signal), wait_for_completion_interruptible returns -ERESTARTSYS. Raw Gadget then attempts to propagate this value to userspace as a return value from its ioctls. However, when -ERESTARTSYS is returned by a syscall handler, the kernel internally restarts the syscall. This doesn't allow userspace applications to interrupt requests queued by Raw Gadget (which is required when the emulated device is asked to switch altsettings). It also violates the implied interface of Raw Gadget that a single ioctl must only queue a single USB request. Instead, make Raw Gadget do what GadgetFS does: check whether the request was interrupted (dequeued with status == -ECONNRESET) and report -EINTR to userspace. Fixes: f2c2e717 ("usb: gadget: add raw-gadget interface") Cc: stable <stable@kernel.org> Signed-off-by:Andrey Konovalov <andreyknvl@gmail.com> Link: https://lore.kernel.org/r/0db45b1d7cc466e3d4d1ab353f61d63c977fbbc5.1698350424.git.andreyknvl@gmail.com Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Zheng Zengkai <zhengzengkai@huawei.com>
Loading
Please sign in to comment