Commit 6475f4bb authored by Arnd Bergmann's avatar Arnd Bergmann
Browse files

ARM: sa1100: address missing prototype warnings 

There are three warnings for mach-sa1100 when building with W=1:

arch/arm/common/sa1111.c:699:1: error: no previous prototype for 'sa1111_configure_smc' [-Werror=missing-prototypes]
  699 | sa1111_configure_smc(struct sa1111 *sachip, int sdram, unsigned int drac,
      | ^~~~~~~~~~~~~~~~~~~~
arch/arm/mach-sa1100/assabet.c:718:13: error: no previous prototype for 'assabet_init_irq' [-Werror=missing-prototypes]
  718 | void __init assabet_init_irq(void)
      |             ^~~~~~~~~~~~~~~~
arch/arm/mach-sa1100/pm.c:126:12: error: no previous prototype for 'sa11x0_pm_init' [-Werror=missing-prototypes]
  126 | int __init sa11x0_pm_init(void)
      |            ^~~~~~~~~~~~~~

The first two are only used locally and can be 'static', while
the last one needs to include the right header.

Link: https://lore.kernel.org/r/20230516153109.514251-12-arnd@kernel.org


Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent a9ae9c52

arch/arm/common/sa1111.c

+1 −1
Original line number Diff line number Diff line
@@ -695,7 +695,7 @@ static u32 sa1111_dma_mask[] = { 
/*

 * Configure the SA1111 shared memory controller.

 */

void

static void

sa1111_configure_smc(struct sa1111 *sachip, int sdram, unsigned int drac,

		     unsigned int cas_latency)

{

arch/arm/mach-sa1100/assabet.c

+1 −1
Original line number Diff line number Diff line
@@ -710,7 +710,7 @@ static void __init assabet_map_io(void) 
	sa1100_register_uart(2, 3);

}



void __init assabet_init_irq(void)

static void __init assabet_init_irq(void)

{

	u32 def_val;

arch/arm/mach-sa1100/pm.c

+2 −0
Original line number Diff line number Diff line
@@ -33,6 +33,8 @@ 
#include <asm/suspend.h>

#include <asm/mach/time.h>



#include "generic.h"



extern int sa1100_finish_suspend(unsigned long);



#define SAVE(x)		sleep_save[SLEEP_SAVE_##x] = x