Commit a9ae9c52 authored by Arnd Bergmann's avatar Arnd Bergmann
Browse files

ARM: pxa: fix missing-prototypes warnings 



The PXA platform has a number of configurations that end up with
a warning like these when building with W=1:

drivers/hwmon/max1111.c:83:5: error: no previous prototype for 'max1111_read_channel' [-Werror=missing-prototypes]
arch/arm/mach-pxa/reset.c:86:6: error: no previous prototype for 'pxa_restart' [-Werror=missing-prototypes]
arch/arm/mach-pxa/mfp-pxa2xx.c:254:5: error: no previous prototype for 'keypad_set_wake' [-Werror=missing-prototypes]
drivers/clk/pxa/clk-pxa25x.c:70:14: error: no previous prototype for 'pxa25x_get_clk_frequency_khz' [-Werror=missing-prototypes]
drivers/clk/pxa/clk-pxa25x.c:325:12: error: no previous prototype for 'pxa25x_clocks_init' [-Werror=missing-prototypes]
drivers/clk/pxa/clk-pxa27x.c:74:14: error: no previous prototype for 'pxa27x_get_clk_frequency_khz' [-Werror=missing-prototypes]
drivers/clk/pxa/clk-pxa27x.c:102:6: error: no previous prototype for 'pxa27x_is_ppll_disabled' [-Werror=missing-prototypes]
drivers/clk/pxa/clk-pxa27x.c:470:12: error: no previous prototype for 'pxa27x_clocks_init' [-Werror=missing-prototypes]
arch/arm/mach-pxa/pxa27x.c:44:6: error: no previous prototype for 'pxa27x_clear_otgph' [-Werror=missing-prototypes]
arch/arm/mach-pxa/pxa27x.c:58:6: error: no previous prototype for 'pxa27x_configure_ac97reset' [-Werror=missing-prototypes]
arch/arm/mach-pxa/spitz_pm.c:170:15: error: no previous prototype for 'spitzpm_read_devdata' [-Werror=missing-prototypes]

The problem is that there is a declaration for each of these, but
it's only seen by the caller and not the callee. Moving these
into appropriate header files ensures that both use the same
calling conventions and it avoids the warnings.

Acked-by: default avatarStephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20230516153109.514251-11-arnd@kernel.org


Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent f8ef1233

arch/arm/mach-pxa/generic.h

+0 −15
Original line number Diff line number Diff line
@@ -27,7 +27,6 @@ extern void __init pxa25x_map_io(void); 
extern void __init pxa26x_init_irq(void);



#define pxa27x_handle_irq ichp_handle_irq

extern unsigned	pxa27x_get_clk_frequency_khz(int);

extern void __init pxa27x_init_irq(void);

extern void __init pxa27x_map_io(void);
@@ -52,18 +51,4 @@ extern void pxa2xx_clear_reset_status(unsigned int); 
static inline void pxa2xx_clear_reset_status(unsigned int mask) {}

#endif



/*

 * Once fully converted to the clock framework, all these functions should be

 * removed, and replaced with a clk_get(NULL, "core").

 */

#ifdef CONFIG_PXA25x

extern unsigned pxa25x_get_clk_frequency_khz(int);

#else

#define pxa25x_get_clk_frequency_khz(x)		(0)

#endif



#ifdef CONFIG_PXA27x

#else

#define pxa27x_get_clk_frequency_khz(x)		(0)

#endif

arch/arm/mach-pxa/mfp-pxa2xx.c

+1 −0
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ 


#include "pxa2xx-regs.h"

#include "mfp-pxa2xx.h"

#include "mfp-pxa27x.h"



#include "generic.h"

arch/arm/mach-pxa/pxa25x.c

+1 −0
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ 
#include <linux/irqchip.h>

#include <linux/platform_data/mmp_dma.h>

#include <linux/soc/pxa/cpu.h>

#include <linux/soc/pxa/smemc.h>



#include <asm/mach/map.h>

#include <asm/suspend.h>

arch/arm/mach-pxa/pxa27x.c

+3 −0
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ 
#include <linux/platform_data/i2c-pxa.h>

#include <linux/platform_data/mmp_dma.h>

#include <linux/soc/pxa/cpu.h>

#include <linux/soc/pxa/smemc.h>



#include <asm/mach/map.h>

#include <asm/irq.h>
@@ -31,7 +32,9 @@ 
#include "irqs.h"

#include "pxa27x.h"

#include "reset.h"

#include <linux/platform_data/pxa2xx_udc.h>

#include <linux/platform_data/usb-ohci-pxa27x.h>

#include <linux/platform_data/asoc-pxa.h>

#include "pm.h"

#include "addr-map.h"

#include "smemc.h"

arch/arm/mach-pxa/reset.c

+1 −0
Original line number Diff line number Diff line
@@ -10,6 +10,7 @@ 
#include "regs-ost.h"

#include "reset.h"

#include "smemc.h"

#include "generic.h"



static void do_hw_reset(void);