Commit 6411e386 authored by Wang Wensheng's avatar Wang Wensheng Committed by Vinod Koul
Browse files

phy: cadence: Sierra: Fix error return code in cdns_sierra_phy_probe() 



Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: a43f72ae ("phy: cadence: Sierra: Change MAX_LANES of Sierra to 16")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWang Wensheng <wangwensheng4@huawei.com>
Link: https://lore.kernel.org/r/20210517015749.127799-1-wangwensheng4@huawei.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 7c2fc792

drivers/phy/cadence/phy-cadence-sierra.c

+1 −0
Original line number Diff line number Diff line
@@ -940,6 +940,7 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev) 
	sp->nsubnodes = node;



	if (sp->num_lanes > SIERRA_MAX_LANES) {

		ret = -EINVAL;

		dev_err(dev, "Invalid lane configuration\n");

		goto put_child2;

	}