Commit 7c2fc792 authored by Chen Li's avatar Chen Li Committed by Vinod Koul
Browse files

phy: usb: Fix misuse of IS_ENABLED 



While IS_ENABLED() is perfectly fine for CONFIG_* symbols, it is not
for other symbols such as __BIG_ENDIAN that is provided directly by
the compiler.

Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.

Signed-off-by: default avatarChen Li <chenli@uniontech.com>
Reviewed-by: default avatarAl Cooper <alcooperx@gmail.com>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Fixes: 94583a41 ("phy: usb: Restructure in preparation for adding 7216 USB support")
Link: https://lore.kernel.org/r/87czuggpra.wl-chenli@uniontech.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 6efb943b

drivers/phy/broadcom/phy-brcm-usb-init.h

+2 −2
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ static inline u32 brcm_usb_readl(void __iomem *addr) 
	 * Other architectures (e.g., ARM) either do not support big endian, or

	 * else leave I/O in little endian mode.

	 */

	if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(__BIG_ENDIAN))

	if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))

		return __raw_readl(addr);

	else

		return readl_relaxed(addr);
@@ -87,7 +87,7 @@ static inline u32 brcm_usb_readl(void __iomem *addr) 
static inline void brcm_usb_writel(u32 val, void __iomem *addr)

{

	/* See brcmnand_readl() comments */

	if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(__BIG_ENDIAN))

	if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))

		__raw_writel(val, addr);

	else

		writel_relaxed(val, addr);