Commit 634b215b authored by XueBing Chen's avatar XueBing Chen Committed by David S. Miller
Browse files

net: ipconfig: use strscpy to replace strlcpy 



The strlcpy should not be used because it doesn't limit the source
length. Preferred is strscpy.

Signed-off-by: default avatarXueBing Chen <chenxuebing@jari.cn>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 798661c7

net/ipv4/ipconfig.c

+4 −4
Original line number Diff line number Diff line
@@ -1759,15 +1759,15 @@ static int __init ip_auto_config_setup(char *addrs) 
			case 4:

				if ((dp = strchr(ip, '.'))) {

					*dp++ = '\0';

					strlcpy(utsname()->domainname, dp,

					strscpy(utsname()->domainname, dp,

						sizeof(utsname()->domainname));

				}

				strlcpy(utsname()->nodename, ip,

				strscpy(utsname()->nodename, ip,

					sizeof(utsname()->nodename));

				ic_host_name_set = 1;

				break;

			case 5:

				strlcpy(user_dev_name, ip, sizeof(user_dev_name));

				strscpy(user_dev_name, ip, sizeof(user_dev_name));

				break;

			case 6:

				if (ic_proto_name(ip) == 0 &&
@@ -1814,7 +1814,7 @@ __setup("nfsaddrs=", nfsaddrs_config_setup); 


static int __init vendor_class_identifier_setup(char *addrs)

{

	if (strlcpy(vendor_class_identifier, addrs,

	if (strscpy(vendor_class_identifier, addrs,

		    sizeof(vendor_class_identifier))

	    >= sizeof(vendor_class_identifier))

		pr_warn("DHCP: vendorclass too long, truncated to \"%s\"\n",