Commit 6292fd92 authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Vinod Koul
Browse files

phy: qcom: qmp-combo: correct bias0_en programming 



It seems the commit a2e927b0 ("phy: qcom-qmp-combo: Add sc8280xp
USB/DP combo phys") contained a typo for selecting bias0_en values.
First, bias0_en and bias1_en are expected to be symmetrical, and then
the vendor driver also uses `flipped : 0x3E : 0x15` statement for
bias0_en. Correct bias0_en programming to follow this.

Fixes: 49742e9e ("phy: qcom-qmp-combo: Add support for SM8550")
Fixes: a2e927b0 ("phy: qcom-qmp-combo: Add sc8280xp USB/DP combo phys")
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20230621153317.1025914-2-dmitry.baryshkov@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 25d70083

drivers/phy/qualcomm/phy-qcom-qmp-combo.c

+2 −2
Original line number Diff line number Diff line
@@ -2322,7 +2322,7 @@ static int qmp_v5_configure_dp_phy(struct qmp_combo *qmp) 
		return ret;



	if (dp_opts->lanes == 1) {

		bias0_en = reverse ? 0x3e : 0x1a;

		bias0_en = reverse ? 0x3e : 0x15;

		drvr0_en = reverse ? 0x13 : 0x10;

		bias1_en = reverse ? 0x15 : 0x3e;

		drvr1_en = reverse ? 0x10 : 0x13;
@@ -2382,7 +2382,7 @@ static int qmp_v6_configure_dp_phy(struct qmp_combo *qmp) 
		return ret;



	if (dp_opts->lanes == 1) {

		bias0_en = reverse ? 0x3e : 0x1a;

		bias0_en = reverse ? 0x3e : 0x15;

		drvr0_en = reverse ? 0x13 : 0x10;

		bias1_en = reverse ? 0x15 : 0x3e;

		drvr1_en = reverse ? 0x10 : 0x13;