Unverified Commit 61163c3e authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

ASoC: codecs: wcd934x: fix kcontrol max values 



set "HPH Type" Kcontrol max value of WCD_MBHC_HPH_STEREO instead of UINT_MAX.
set "HPHL/R Impedance" Kcontrols max value to INT_MAX instead of UINT_MAX as
max field is integer type.

Without this patch amixer for these controls will show -1 as max value to userspace.

Fixes: 9fb9b169 ("ASoC: codecs: wcd934x: add mbhc support")
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220222183212.11580-9-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b0217519

sound/soc/codecs/wcd934x.c

+3 −3
Original line number Diff line number Diff line
@@ -3023,14 +3023,14 @@ static int wcd934x_hph_impedance_get(struct snd_kcontrol *kcontrol, 
	return 0;

}

static const struct snd_kcontrol_new hph_type_detect_controls[] = {

	SOC_SINGLE_EXT("HPH Type", 0, 0, UINT_MAX, 0,

	SOC_SINGLE_EXT("HPH Type", 0, 0, WCD_MBHC_HPH_STEREO, 0,

		       wcd934x_get_hph_type, NULL),

};



static const struct snd_kcontrol_new impedance_detect_controls[] = {

	SOC_SINGLE_EXT("HPHL Impedance", 0, 0, UINT_MAX, 0,

	SOC_SINGLE_EXT("HPHL Impedance", 0, 0, INT_MAX, 0,

		       wcd934x_hph_impedance_get, NULL),

	SOC_SINGLE_EXT("HPHR Impedance", 0, 1, UINT_MAX, 0,

	SOC_SINGLE_EXT("HPHR Impedance", 0, 1, INT_MAX, 0,

		       wcd934x_hph_impedance_get, NULL),

};