Commit 60df28ac authored by Li Zetao's avatar Li Zetao Committed by Greg Kroah-Hartman
Browse files

misc: eeprom/idt_89hpesx: Use devm_kmemdup to replace devm_kmalloc + memcpy 



Use the helper function devm_kmemdup() rather than duplicating its
implementation, which helps to enhance code readability.

Signed-off-by: default avatarLi Zetao <lizetao1@huawei.com>
Reviewed-by: default avatarLuca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://lore.kernel.org/r/20230810115049.2104099-1-lizetao1@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 183238ff

drivers/misc/eeprom/idt_89hpesx.c

+6 −5
Original line number Diff line number Diff line
@@ -1288,14 +1288,15 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev) 
		return 0;

	}



	/* Allocate memory for attribute file */

	pdev->ee_file = devm_kmalloc(dev, sizeof(*pdev->ee_file), GFP_KERNEL);

	/*

	 * Allocate memory for attribute file and copy the declared EEPROM attr

	 * structure to change some of fields

	 */

	pdev->ee_file = devm_kmemdup(dev, &bin_attr_eeprom,

				     sizeof(*pdev->ee_file), GFP_KERNEL);

	if (!pdev->ee_file)

		return -ENOMEM;



	/* Copy the declared EEPROM attr structure to change some of fields */

	memcpy(pdev->ee_file, &bin_attr_eeprom, sizeof(*pdev->ee_file));



	/* In case of read-only EEPROM get rid of write ability */

	if (pdev->eero) {

		pdev->ee_file->attr.mode &= ~0200;