Commit 183238ff authored by Ruan Jinjie's avatar Ruan Jinjie Committed by Greg Kroah-Hartman
Browse files

misc: eeprom/idt_89hpesx: Switch to memdup_user_nul() helper 



Use memdup_user_nul() helper instead of open-coding to simplify the code.

Signed-off-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: default avatarLuca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://lore.kernel.org/r/20230810121608.2110328-1-ruanjinjie@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 25a7de32

drivers/misc/eeprom/idt_89hpesx.c

+3 −9
Original line number Diff line number Diff line
@@ -913,15 +913,9 @@ static ssize_t idt_dbgfs_csr_write(struct file *filep, const char __user *ubuf, 
		return 0;



	/* Copy data from User-space */

	buf = kmalloc(count + 1, GFP_KERNEL);

	if (!buf)

		return -ENOMEM;



	if (copy_from_user(buf, ubuf, count)) {

		ret = -EFAULT;

		goto free_buf;

	}

	buf[count] = 0;

	buf = memdup_user_nul(ubuf, count);

	if (IS_ERR(buf))

		return PTR_ERR(buf);



	/* Find position of colon in the buffer */

	colon_ch = strnchr(buf, count, ':');